Skip to content

Fix #9016: Fix stackoverflows in provablyDisjoint #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 21, 2020

No description provided.

odersky added 2 commits May 21, 2020 14:19
Surely, two intersection types A1 & A2 and B1 & B2 are provable disjoint
if any pair of A_i and B_j is provably disjoint? This is already handled
by the single-side cases for AndTypes. The dropped case imposed
a stronger condition.
@odersky
Copy link
Contributor Author

odersky commented May 21, 2020

@liufengyun Can you please check that the exhaustivity test changes are correct?

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exhaustivity changes LGTM

@OlivierBlanvillain OlivierBlanvillain merged commit 484e3c6 into scala:master May 22, 2020
@OlivierBlanvillain OlivierBlanvillain deleted the fix-#9011 branch May 22, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants