Fix #8976: Do not instantiate type variables outside bounds #9010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
Using <:< leads to a non-terminating or very long compile when compiling scalatest
smarter
requested changes
May 20, 2020
Comment on lines
+4221
to
+4224
| * - It is checked that the resulting type still fits within | ||
| * bounds. If not, a `NoInstance` exception is thrown, | ||
| * but only after instantiating the variable anyway because | ||
| * this avoids follow-on errors. |
There was a problem hiding this comment.
I'm not convinced this is needed:
avoidCapturesalready checks that the approximation is within bound and throws an exception if it isn'twidenInferredwill not do any widening if that would be out of bounds
The only problematic piece is approximation in ConstraintHandling which will replace recursive occurences of the type variable being instantiated by TypeBounds.empty, which can indeed be unsound. Here's an alternative PR which tries to fix that specific problem: #9012
|
Closed in favor of #9012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid instantiations of type variables that do not fit their bounds. Throw a TypeError instead.