ClassfileParser: Java8 bytecode (fixes #83) #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. The changes look all good to me. |
|
LGTM. That's a good start. The type checker and refchecks will need to interpret the default method flag (no need to override it, SAM types can be formed for Java interfaces with some defaults), but you'll pick these up as you import test cases. |
| case tpnme.CodeATTR => | ||
| if (sym.owner is Flags.Interface) { | ||
| sym.setFlag(Flags.DefaultMethod) | ||
| ctx.log(s"$sym in ${sym.owner} is a java8+ default method.") |
There was a problem hiding this comment.
Not sure if this is log worthy, one can see this on the flags of the method later on.
There was a problem hiding this comment.
I just added this because scalac also logs it
odersky
added a commit
that referenced
this pull request
Mar 22, 2014
ClassfileParser: Java8 bytecode (fixes #83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all commits in
and applied them to dotty where possible. Running
now succeeds, no more errors like in #83