Fix #8349: Generic signatures of generic arrays #8361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested review from
anatoliykmetyuk
and removed request for
odersky
anatoliykmetyuk
approved these changes
Mar 3, 2020
When T[] is erased to Object, it should get a Java generic signature of Object and not of T<>. Fixed by reusing the same logic we have in TypeErasure which replaces a bunch of weird code imported from scalac. The new behavior differs in one case from scalac: `Array[_ <: Byte]` gets a generic signature of `byte[]` instead of `Object`, but this is consistent with how we handle erasure (which I think is OK because as far as I can tell, we can't construct a value of type `Array[Nothing]` with Dotty).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When T[] is erased to Object, it should get a Java generic signature of
Object and not of T<>. Fixed by reusing the same logic we have in
TypeErasure which replaces a bunch of weird code imported from scalac.
The new behavior differs in one case from scalac:
Array[_ <: Byte]gets a generic signature of
byte[]instead ofObject, but this isconsistent with how we handle erasure (which I think is OK because as
far as I can tell, we can't construct a value of type
Array[Nothing]with Dotty).