Accept 0x_42, reject 0x #8269
Merged
Accept 0x_42, reject 0x #8269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 10, 2020
|
More bad syntax tests could be unleashed in a follow-up. It's nice that dotty corrects us with a caret and not a carrot: For some reason, float gets only one. |
Forward port fix on 2.11 for `0x`. 2.13 accepts 0x_42 and was affirmed. Also accept leading zero for decimals. People like their literals to align left and right. List(0000, 3.14) will harmonize vertically! Leading zero is lintable in 2.13.
som-snytt
force-pushed
the
issue/numbers
branch
from
5d0a0e0 to
149e862
Compare
odersky
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port fix on 2.11 for
0x.2.13 accepts 0x_42 and was affirmed.
Also accept leading zero for decimals.
People like their literals to align left and right.
List(0000, 3.14)will harmonize vertically!Leading zero is lintable in 2.13.
scala/scala@be553aa
Discussion affirming
0x_42on scala/scala#8020 (a PR to fix caret position on error messages).