Remove unnecessary unsafe casts in IArray and fix erroneous cast #8196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 4, 2020
|
You will need to adapt TupleOptimizations.scala to pass |
|
@nicolasstucki thanks, I've made the changes (boy, that was painful to do). |
nicolasstucki
previously requested changes
Feb 5, 2020
|
@nicolasstucki I've resolved the issues. |
odersky
approved these changes
Feb 10, 2020
|
Just needs a rebase. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 61 unnecessary usages of
asInstanceOfinIArray.scala. Many of them were completely unneeded, and the rest could be avoided via simple typing tricks, without adding any overhead.I think unsafe casts should be avoided as much as possible. This is not just a theoretical issue: while making the changes, I discovered a bug in the implementation of
IArray#exists(see #8195 (comment) for more info).I used a private inline implicit conversion for convenience in the
IArrayobject. I tried to use an instance ofConversioninstead, but that did not work because of #8194.