Fix #8058: Fix isStableMember test
#8062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isStableMember classified NoSymbol as stable. This meant that an Application without a symbol was classified as pure in TreeInfo. This in turn meant that the application could be dropped and replaced with `Unit` at the end of a block. The (non-)pure application in the test was an array update.
Before the fix to scala#8058, a reference `x` with constant type `0` was deemed to have a stable member symbol since its symbol did not exist. That's what gave the reference the `PurePath` status. Now that `isStableMember` is fixed, this needs to be asserted explicitly.
TermRefs that do not have a symbol should not be widened under widenIfUnstable.
|
We get an unresolved dependency in dotty-bootstrap: org.scala-js#scalajs-linker_2.12;1.0.0-RC2: That's what causes all the builds to fail. |
|
sigh, we got banned from sonatype again, I'll look into it: |
|
Should be OK if you rebase on master now that #8071 is merged. |
|
Great, thanks for the quick intervention! |
smarter
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isStableMember classified NoSymbol as stable. This meant that
an Application without a symbol was classified as pure in TreeInfo.
This in turn meant that the application could be dropped and replaced
with
Unitat the end of a block. The (non-)pure application inthe test was an array update.