Skip to content

Add detailed message for case class missing non-implicit parameter list #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

Add detailed message for case class missing non-implicit parameter list #7729

merged 1 commit into from
Jan 17, 2020

Conversation

hope-doe
Copy link

No description provided.

@hope-doe hope-doe mentioned this pull request Dec 12, 2019
Closed
smarter
smarter requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, but could you edit the title of your commit message to be a sentence? I suggest "Add detailed message for case class missing non-implicit parameter list"

@hope-doe
Copy link
Author

Cool, sure!

@hope-doe hope-doe force-pushed the issue-1589-error-mes-case-class-missing-non-implicit-param-list branch from 82b9cf5 to 340ef80 Compare December 13, 2019 07:44
@hope-doe hope-doe changed the title issue-1589--error-mes-case-class-missing-non-implicit-param-list Add detailed message for case class missing non-implicit parameter list Dec 13, 2019
@OlivierBlanvillain
Copy link
Contributor

@hope-doe Can you also sign the CLA?

@hope-doe
Copy link
Author

@hope-doe Can you also sign the CLA?

done! cla is signed

@hope-doe hope-doe force-pushed the issue-1589-error-mes-case-class-missing-non-implicit-param-list branch from 340ef80 to c560174 Compare January 15, 2020 10:57
@hope-doe hope-doe force-pushed the issue-1589-error-mes-case-class-missing-non-implicit-param-list branch from c560174 to d3cf3a3 Compare January 16, 2020 13:27
@OlivierBlanvillain OlivierBlanvillain merged commit 4b9333a into scala:master Jan 17, 2020
@OlivierBlanvillain
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hope-doe @OlivierBlanvillain @smarter