Fix #3495: Improve handling of getClass #7345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not clear what this was supposed accomplish. The referred to test case, t5568, compiles and runs with reasonable output. It was moved from pending to run.
The new assumed signature is
def getClass[A >: this.type](): Class[? <: A]
This matches what scalac does, without requiring special machinery in
the type checker and inferencer.
liufengyun
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
LGTM
Not caused by this PR -- Dotty and Scalac disagrees in the following code:
Dotty:
scala> (5.asInstanceOf[AnyRef & Int]).getClass
val res0: Class[Int] = int
scala> (5.asInstanceOf[Int & AnyRef]).getClass
val res1: Class[Int] = intScalac:
scala> (5.asInstanceOf[AnyRef with Int]).getClass
res1: Class[_ <: AnyRef] = class java.lang.Integer
scala> (5.asInstanceOf[Int with AnyRef]).getClass
res2: Class[_ <: Int] = class java.lang.Integer
|
Yes, there was special treatment that should have had this effect and that I eliminated in 79fb64e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new assumed signature is
This matches what scalac does, without requiring special machinery in
the type checker and inferencer.