Skip to content

Remove trace in adaptBoxed #22791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Remove trace in adaptBoxed #22791

merged 1 commit into from
Mar 24, 2025

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Mar 13, 2025

The project currently doesn't clean compile with tracing enabled because there is a return in a trace block in CheckCaptures.scala, which is a non-local return when tracing is enabled.

[info] compiling 595 Scala sources and 8 Java sources to /localhome/bovel/scala3/compiler/target/scala-3.6.4-RC1/classes ...
[warn] -- Warning: /localhome/bovel/scala3/compiler/src/dotty/tools/dotc/cc/CheckCaptures.scala:1387:14 
[warn] 1387 |              return actual
[warn]      |              ^^^^^^^^^^^^^
[warn]      |Non local returns are no longer supported; use `boundary` and `boundary.break` in `scala.util` instead
[error] No warnings can be incurred under -Werror (or -Xfatal-warnings)
[warn] one warning found
[error] one error found
[error] (scala3-compiler / Compile / compileIncremental) Compilation failed
[error] Total time: 26 s, completed Mar 13, 2025, 10:09:01 AM

Interestingly, first compiling with tracingEnabled = false and then switching to true works 🤔

@mbovel mbovel requested a review from odersky March 20, 2025 14:51
@odersky odersky merged commit ee4c68a into scala:main Mar 24, 2025
30 checks passed
@odersky odersky deleted the mb/fix-trace branch March 24, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants