Skip to content

Add regression test for i19675 #21159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

jchyb
Copy link
Contributor

@jchyb jchyb commented Jul 10, 2024

Originally fixed by #19926
Closes #19675

Even though this is a slower sbt scripted test, I think it's worth adding, since it showcases a different issue than what #19926 was fixing, and I do not believe it is reproducible in any way without a scala-2 dependency (so we cannot minimize it into regular compilation test).

@jchyb jchyb requested a review from Gedochao August 19, 2024 13:11
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 53a40b4 into scala:main Aug 20, 2024
24 checks passed
WojciechMazur pushed a commit that referenced this pull request Aug 28, 2024
Originally fixed by #19926
Closes #19675

Even though this is a slower sbt scripted test, I think it's worth
adding, since it showcases a different issue than what #19926 was
fixing, and I do not believe it is reproducible in any way without a
scala-2 dependency (so we cannot minimize it into regular compilation
test).
[Cherry-picked 53a40b4]
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
Backports #21159 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
WojciechMazur pushed a commit that referenced this pull request Dec 3, 2024
Originally fixed by #19926
Closes #19675

Even though this is a slower sbt scripted test, I think it's worth
adding, since it showcases a different issue than what #19926 was
fixing, and I do not believe it is reproducible in any way without a
scala-2 dependency (so we cannot minimize it into regular compilation
test).
[Cherry-picked 53a40b4]
WojciechMazur added a commit that referenced this pull request Dec 4, 2024
Backports #21159 to the 3.3.5.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive deprecation warnings when -Wunused:imports is used in 3.4.0-RCx
2 participants