Backport "Fix goto-def on exported forwarders" to LTS #20872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Cherry-picked 32b00f4]
Given:
class Foo(name: String, age: Int)
case class Person(name: String)
Is the Foo constructor symbol synthetic? Being the primary
constructor, sourceSymbol considers it should be substituted for the Foo
class symbol.
Similarly, the Person apply method symbol is replaced by the class
symbol for Person (via the Person module class).
Doing so leads the presentation compiler to show details about the
class, rather than the constructor or the apply method intially
targeted.
[Cherry-picked 6792fc7]
[Cherry-picked 6aadd94]
[Cherry-picked 03c9b3e]
[Cherry-picked 4e532e9]
[Cherry-picked 050d11d]
[Cherry-picked 2a02773]
Tested by giving exportTerm0 and exportTerm1 difference filenames, resulting in different locations and breakage. [Cherry-picked 0ee03ef]
|
No regressions detected in the community build up to lts-19605. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #19494 to the LTS branch.
PR submitted by the release tooling.
[skip ci]