Refactor split quote symbol mapping #18104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Jun 30, 2023
| case tp => mapOver(tp) | ||
| } | ||
| } | ||
| val replaceBindings = new ReplaceBindings | ||
| val patType = defn.tupleType(splices.tpes.map(tpe => replaceBindings(tpe.widen))) | ||
|
|
||
| val typeBindingsTuple = tpd.hkNestedPairsTypeTree(typeBindings.values.toList) | ||
| val typeBinds = bindSymMapping.values.toList.map(sym => |
There was a problem hiding this comment.
Putting the toList after the map would be more efficient I believe.
There was a problem hiding this comment.
Moved the toList after the map
Now, the mapping is a `SeqMap[Symbol, Symbol]` to convey its ordering and the `Bind` is created when we are creating the tree of the quote pattern.
nicolasstucki
force-pushed
the
fix-quote-type-variable-bounds-2
branch
from
1560388 to
9044c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the mapping is a
SeqMap[Symbol, Symbol]to convey its ordering and theBindis created when we are creating the tree of the quote pattern.Follow up of the refactoring in #17956