Skip to content

Preserve type bounds for inlined definitions in posttyper #17190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2023
Merged

Preserve type bounds for inlined definitions in posttyper #17190

merged 2 commits into from
May 15, 2023

Conversation

Decel
Copy link
Contributor

@Decel Decel commented Mar 30, 2023

Fixes #17168, as per @odersky idea.

@Decel Decel changed the title Preserve F-bounds for inlined definitions in posttyper Preserve type bounds for inlined definitions in posttyper Mar 30, 2023
@Decel Decel marked this pull request as draft March 30, 2023 23:37
@Decel Decel marked this pull request as ready for review April 24, 2023 10:31
@dwijnand dwijnand self-assigned this Apr 27, 2023
nicolasstucki
nicolasstucki previously requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to be more careful with that recursion.

We already know about 2 unintended consequences, and we may be missing something else.

@odersky
Copy link
Contributor

odersky commented May 5, 2023

Yes, let's back out of the last commit.

@dwijnand
Copy link
Member

dwijnand commented May 5, 2023

The last commit has the wrong indentation.

@nicolasstucki nicolasstucki dismissed their stale review May 12, 2023 08:08

I added a commit addressing my concern

nicolasstucki
nicolasstucki reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Decel commit LGTM.

@dwijnand could you review the commit I added?

@nicolasstucki nicolasstucki requested a review from dwijnand May 12, 2023 08:09
@dwijnand dwijnand merged commit d28ac36 into scala:main May 15, 2023
@Decel Decel deleted the i17168 branch May 31, 2023 12:31
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki left review comments

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Summon allows to ignore type bounds
5 participants
@Decel @odersky @dwijnand @nicolasstucki @Kordyjan