Skip to content

Fix #1614 tailrec. #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2016
Merged

Fix #1614 tailrec. #1620

merged 2 commits into from
Oct 25, 2016

Conversation

DarkDimius
Copy link
Contributor

@DarkDimius DarkDimius commented Oct 23, 2016 •
edited
Loading

A straightforward simple fix for tailrec.

@DarkDimius
Fix scala#1614: correctly handle polymorphic inner methods
bcb652b 
Even if outer class & method isn't polymorpnic,
inner method might be. Need to handle this correctly.
@DarkDimius
Test that scala#1614 remains fixed.
20cbcca
@DarkDimius DarkDimius changed the title [WIP] Fix #1614 tailrec. Fix #1614 tailrec. Oct 25, 2016
@DarkDimius
Copy link
Contributor Author

ready for review. @felixmulder would you like to review it?

felixmulder
felixmulder approved these changes Oct 25, 2016
View reviewed changes
Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing ⭐ ⭐ ⭐ ⭐ ⭐

@felixmulder felixmulder merged commit 133fbb3 into scala:master Oct 25, 2016
@felixmulder
Copy link
Contributor

Ping: @matthewfarwell

@allanrenucci allanrenucci deleted the fix-1614 branch December 14, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmulder felixmulder felixmulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkDimius @felixmulder