Skip to content

community build: Fix publishing for scala-xml #15774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Jul 28, 2022

While investigating some community build failures in #15728, I noticed that publishLocal for scala-xml wasn't doing anything. It turns out that its build is configured to skip publishing for Scala versions > 3.0.x.

@SethTisue
Copy link
Member

we merged scala/scala-xml#615 recently — pulling that in might take care of it?

@SethTisue
Copy link
Member

oh, ha, no. I'll need to send a sequel PR. working on it

@griggt
Copy link
Contributor Author

griggt commented Jul 28, 2022

we merged scala/scala-xml#615 recently — pulling that in might take care of it?

Hmmm...
https://github.com/scala/scala-xml/blob/354cd71f55410ecd497c1cefd2eb2048555fab90/build.sbt#L41

@SethTisue
Copy link
Member

scala/scala-xml#616

Allows publishLocal for Scala versions > 3.0.x, so other community build
projects can depend on `scala-xml` and get the in-build artifacts.
@griggt griggt force-pushed the cb/publish-scala-xml branch from b209e27 to 2e53dea Compare July 28, 2022 05:30
@griggt
Copy link
Contributor Author

griggt commented Jul 28, 2022

updated to pull in scala/scala-xml#616

@ckipp01 ckipp01 merged commit e439ad0 into scala:main Jul 28, 2022
@griggt griggt deleted the cb/publish-scala-xml branch July 28, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants