Fix reflect typeMembers to return all members #15033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pushed a commit repairing Scaladoc tests |
nicolasstucki
force-pushed
the
fix-14902
branch
from
500ce16 to
efc8081
Compare
Did not notice this commit and force pushed the fix I had. @pikinier20 is this the same fix that you did? |
Yes, it is. Sorry for messing up :) |
pikinier20
reviewed
Apr 26, 2022
|
Note that the other fixes in the documentation are in #15034 |
smarter
requested changes
Apr 26, 2022
nicolasstucki
force-pushed
the
fix-14902
branch
from
efc8081 to
60f46a6
Compare
smarter
reviewed
Nov 17, 2022
| @@ -2619,13 +2619,15 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler | |||
| case sym if sym.isType => sym.asType | |||
| }.toList | |||
|
|
|||
| def memberType(name: String): Symbol = typeMember(name) | |||
| def typeMember(name: String): Symbol = | |||
| def memberType(name: String): Symbol = | |||
| self.unforcedDecls.find(sym => sym.name == name.toTypeName) | |||
There was a problem hiding this comment.
I guess this was present before, but any reason we use unforcedDecls here? That could also miss declarations.
There was a problem hiding this comment.
I do not belive there was a particular reason. Which method would you use instead?
nicolasstucki
force-pushed
the
fix-14902
branch
from
ca79663 to
10289a9
Compare
smarter
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14902