Skip to content

Enable explicit nulls for all compile #14946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Apr 14, 2022

Since the reference compiler is updated in #14934 , now we can enable explicit nulls for all compile and remove some redundent uncheckedNN in the code.

@noti0na1 noti0na1 force-pushed the enable-explicit-nulls-all branch from a7a9a7b to c322cf2 Compare July 12, 2022 07:59
@ckipp01
Copy link
Member

ckipp01 commented May 10, 2023

Hey @noti0na1, do you have any plans to return to this? Are you will to rebase and see if we can get a review on this? I see that this is listed as a blocker for #15127.

@olhotak
Copy link
Contributor

olhotak commented May 10, 2023

The blocker to this was not need for a review but pickling consistency (i.e. the pickling tests were not passing due to equivalent but different types). #15515 was one attempt to fix those pickling inconsistencies.

@noti0na1
Copy link
Member Author

Outdated

Both bootstrapped and non-bootstrapped versions are already compiled with explicit nulls.

@noti0na1 noti0na1 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants