-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable explicit nulls for all compile #14946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0faca6f
to
538bb7b
Compare
3141a4c
to
9d12c6f
Compare
9d12c6f
to
a7a9a7b
Compare
a7a9a7b
to
c322cf2
Compare
The blocker to this was not need for a review but pickling consistency (i.e. the pickling tests were not passing due to equivalent but different types). #15515 was one attempt to fix those pickling inconsistencies. |
Outdated Both bootstrapped and non-bootstrapped versions are already compiled with explicit nulls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the reference compiler is updated in #14934 , now we can enable explicit nulls for all compile and remove some redundent
uncheckedNN
in the code.