add scala-java8-compat and jackson-module-scala to community build #13168
Conversation
There was a problem hiding this comment.
It seems that this has a binary dependency on the Scala 3 artifact scala-java8-compat_3-1.0.0.jar
The projects in the community build normally build all their Scala 3 dependencies from source, which would mean adding scala-java8-compat to the community build together here with jackson-module-scala.
wdyt @anatoliykmetyuk
|
Yes, it would be good not to break the existing convention and also include the |
|
@anatoliykmetyuk @griggt I've added scala-java8-compat to this PR |
| @@ -792,6 +805,7 @@ def allProjects = List( | |||
| projects.scalacheckEffect, | |||
| projects.fs2, | |||
| projects.libretto, | |||
| projects.jacksonModuleScala, | |||
There was a problem hiding this comment.
Why isn't the java8-compat included in this list?
There was a problem hiding this comment.
apologies - missed that, I've fixed up the PR to include that
add scala-java8-compat add scalaJava8Compat
pjfanning
changed the title
|
the CI build is failing due to org.scala-lang:scala-compiler:3.0.3-RC1-bin-SNAPSHOT and other related jars not being found |
The code uses the Scala 2 compiler API
I've pushed a workaround |
I tried to follow the steps in https://github.com/lampepfl/dotty/tree/master/community-build - feel free to request changes