Fix #12729: Don't encode <init> and <clinit> only. #12901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jun 22, 2021
| @@ -0,0 +1,3 @@ | |||
| class Test(i: Int): | |||
| val `<init>` = "init" // error: Illegal backquoted identifier: `<init>` and `<clinit>` are forbidden | |||
There was a problem hiding this comment.
You should also test that class `<init>` and def `<init>` are rejected
mlachkar
force-pushed
the
fix-name-with-smaller-than
branch
from
1dd1d24 to
ef27b1e
Compare
smarter
approved these changes
Jun 24, 2021
Comment on lines
345
to
346
| length >= 6 && | ||
| head == '<' && (this == StdNames.nme.CONSTRUCTOR || this == StdNames.nme.STATIC_CONSTRUCTOR) |
There was a problem hiding this comment.
This can be simplified to just checking if this is CONSTRUCTOR or STATIC_CONSTRUCTOR, the checks for length and head aren't needed anymore.
There was a problem hiding this comment.
you're right! thanks
|
Very minor point but when fixing up a mistake in a previous commit, don't hesitate to squash these commits together and push-force, this makes the git history more readable. |
mlachkar
force-pushed
the
fix-name-with-smaller-than
branch
from
1492159 to
58ff556
Compare
In addition, reject `<init>` and `<clinit>` in the parser, so that users don't write them in source code.
mlachkar
force-pushed
the
fix-name-with-smaller-than
branch
from
58ff556 to
30191db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, reject
<init>and<clinit>in the parser, so thatusers don't write them in source code.
fixes #12729