-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Align compiler options to VWXY scheme #12751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b368c22
to
c7d0b75
Compare
Let me know if I should do something. I have to say, it's so much easier to find verbose output under -V than trying -help then -X then -Y trying to find the option I need. There is still the issue of "support". History shows that all options are equally ephemeral like all software. |
@romanowski I won't be able to get to this for several days so it'd be better if someone else reviewed it. |
protected def isVerbose(s: Setting[?])(using settings: ConcreteSettings)(using SettingsState): Boolean = | ||
s.name.startsWith("-V") && s.name != "-V" | ||
protected def isWarning(s: Setting[?])(using settings: ConcreteSettings)(using SettingsState): Boolean = | ||
s.name.startsWith("-W") && s.name != "-W" || s.name == "-Xlint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one option of a kind -V
and -W
each added in this PR. Is it worth creating these two categories? What's the motivation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets a thousand flowers bloom and still be manageable. https://github.com/lampepfl/dotty/issues/12785
If I want more output merely (not change in behavior), -V
is more succinct than checking -X
and -Y
(which become a long list eventually). Everyone needs -Vprint
at some point, not just compiler coders.
(But here, I just wanted to say -Wconf
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another motivation is alignment with Scala 2.
by @som-snytt