Skip to content

Add Libretto to community build. #12558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

TomasMikula
Copy link
Contributor

I would like to add Libretto to the community build.

@TomasMikula TomasMikula force-pushed the libretto branch 2 times, most recently from 8db7f83 to e37e389 Compare May 22, 2021 09:13
@TomasMikula
Copy link
Contributor Author

Is there a way to re-run the build so that it checks out the HEAD of Libretto's master branch? I have tried to trigger a new build twice with a force push, but an old commit was checked out both times.

@smarter
Copy link
Member

smarter commented May 23, 2021

a git submodule points to a commit, not to a branch. To update it one needs to go into the submodule, checkout the correct commit, cd back outside, git add the submodule directory, then commit.

@TomasMikula
Copy link
Contributor Author

Thanks, updated, new build started.

@anatoliykmetyuk
Copy link
Contributor

Thanks for contributing this @TomasMikula! Could you please point the submodule to https://github.com/dotty-staging/libretto ? I've also added you to that repo.

@TomasMikula
Copy link
Contributor Author

@anatoliykmetyuk Done.

@anatoliykmetyuk anatoliykmetyuk merged commit fe2fcc4 into scala:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants