Scaladoc: Fix problems with documenting scala.js projects #12364
Conversation
| .partition(commonScalaSettings.contains) | ||
| shared.foreach(setInGlobal) | ||
|
|
||
| if !other.isEmpty then report.echo(s"Skipping unused scalacOptions: ${other.map(_.name).mkString(", ")}") |
There was a problem hiding this comment.
If sbt automatically passes these options to scaladoc, then we shouldn't display this message to the user since they can't do anything about it, so it would just be noise.
There was a problem hiding this comment.
I thought that it's nice to inform (instead of warn) an user that these options were passed to scaladoc but are unused. Doing it silentely might be confusing when someone adds compile options by:
Compile / doc / scalacOptions ++= ...
And won't know why they are not working. What do you think?
There was a problem hiding this comment.
If we could distinguish which options were user-defined and which were just copied from Compile / scalacOptions that would be nice indeed, but as it is I'm not sure.
There was a problem hiding this comment.
I think we should print this message using the info or debug level since in most cases this will be noise but in few rare cases, this may save quite a lot of debugging.
Will work after sbt release with #6499
closes: #12298