Fix #11592: Scala.js: Handle default params of native JS classes. #11857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They must not be emitted, just like regular methods inside native JS classes are not emitted. This ensures that if the default value is `= js.native`, it is not emitted, and therefore does not report an error tha calling `js.native` is illegal in non-native code.
nicolasstucki
approved these changes
Mar 23, 2021
nicolasstucki
deleted the
sjs-fix-default-params-in-js-native-class-ctor
branch
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Mar 24, 2021
…ams-in-js-native-class-ctor Fix scala#11592: Scala.js: Handle default params of native JS classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They must not be emitted, just like regular methods inside native JS classes are not emitted.
This ensures that if the default value is
= js.native, it is not emitted, and therefore does not report an error tha callingjs.nativeis illegal in non-native code.This is in fact a blocker to upgrade scalajs-dom to Scala 3, so I'm assigning it to 3.0.0-RC2. It should be straightforward.