Skip to content

Remove reflect ClassDef derived #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

Remove reflect ClassDef derived #11756

merged 1 commit into from
Mar 17, 2021

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 15, 2021 •
edited
Loading

This field is always Nil after desugaring.

@nicolasstucki nicolasstucki marked this pull request as ready for review March 15, 2021 17:03
@nicolasstucki
Copy link
Contributor Author

Will need rebase on top of #11754

liufengyun
liufengyun approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Needs to rebase and fix the CI.

@nicolasstucki nicolasstucki force-pushed the remove-reflect-classdef-derived branch from 26bccdd to 0048836 Compare March 17, 2021 15:14
@nicolasstucki nicolasstucki enabled auto-merge March 17, 2021 15:20
@nicolasstucki nicolasstucki force-pushed the remove-reflect-classdef-derived branch from 0048836 to 3f900c0 Compare March 17, 2021 16:07
@nicolasstucki nicolasstucki merged commit 2caf209 into scala:master Mar 17, 2021
@nicolasstucki nicolasstucki deleted the remove-reflect-classdef-derived branch March 17, 2021 17:55
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan