Skip to content

Remove indirection of IArray operations #11320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Feb 4, 2021

Part of #11298

@odersky
Copy link
Contributor

odersky commented Feb 8, 2021

It would be good to do some micro-benchmarks about performance of array operations vs IArray operations. Ideally the performance should be the same after warmup. We should test direct access with apply as well as common collection operations such as map, flatMap, filter, foldLeft. And we should test with elements of both primitive and reference types.

@nicolasstucki
Copy link
Contributor Author

This change will not really help with performance. It only makes the module initialization a bit sorter.

Both #11319 and #11329 take advantage of this change on a semantic level as it prioritizes these extension methods over implicit conversion.

@nicolasstucki
Copy link
Contributor Author

This also removes the indirection on the docs

@nicolasstucki nicolasstucki marked this pull request as ready for review February 8, 2021 12:57
@nicolasstucki nicolasstucki mentioned this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants