Move QuoteContext implementation to scala.quoted.internal.impl #10293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Nov 12, 2020
|
|
||
| import scala.quoted._ | ||
| package scala.quoted | ||
| package internal.impl |
There was a problem hiding this comment.
What is the consideration here for prefering scala.quoted. internal.impl over dotty.tools.dotc.quoted?
There was a problem hiding this comment.
We need to add ExprImpl and TypeImpl in the scala package as Expr/Type have private[scala] constructors. If we have that it also makes sense to put the other related classes in there for consistency.
nicolasstucki
force-pushed
the
move-quote-context-implementation
branch
from
9e13ecc to
67f4419
Compare
* `scala.quoted.internal.impl` is defined in the compiler
* Remove `scala.quoted.internal.{Expr,Type}`
* Move all classes related to the implemetation of the QuoteContext into `impl`
nicolasstucki
force-pushed
the
move-quote-context-implementation
branch
from
67f4419 to
c77d0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala.quoted.internal.implis defined in the compilerscala.quoted.internal.{Expr,Type}impl