Move Reflection to scala.quoted #10291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
move-Reflection
branch
2 times, most recently
from
093ee7d to
65a19db
Compare
nicolasstucki
force-pushed
the
move-Reflection
branch
from
65a19db to
a531d64
Compare
In theory it should be inside of the QuoteContext but this is blocked by scala#10253. We take this first step to cleanup the `scala.tasty` package Also fix code that uses Reflection directly.
nicolasstucki
force-pushed
the
move-Reflection
branch
from
a531d64 to
60d5820
Compare
romanowski
approved these changes
Nov 12, 2020
abgruszecki
approved these changes
Nov 12, 2020
|
I'm exploring an alternative to the |
|
It is a bit weird that this makes many micro-benchmarks slower. |
|
I noticed. Maybe there are more situations where we need to load this class file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory it should be inside of the QuoteContext but this is blocked by #10253.
We take this first step to cleanup the
scala.tastypackage.