-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Failing to resolve to correct StringContext #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area:desugar
Desugaring happens after parsing but before typing, see desugar.scala
help wanted
itype:bug
Comments
or |
This is intentional in scalac, but I agree that it's not a feature worth preserving: https://github.com/scala/scala/blob/2.13.x/src/compiler/scala/tools/nsc/ast/parser/Parsers.scala#L1374-L1376 |
lloydmeta
added a commit
to lloydmeta/dotty
that referenced
this issue
Jul 8, 2018
Closes scala#4732 * Make desugared `s""` call `_root_.scala.StringContext` instead of just `StringContext` * Adds a test
lloydmeta
added a commit
to lloydmeta/dotty
that referenced
this issue
Jul 8, 2018
* Make desugared `s""` call `_root_.scala.StringContext` instead of just `StringContext` * Add a unit test
lloydmeta
added a commit
to lloydmeta/dotty
that referenced
this issue
Jul 8, 2018
* Make desugared `s""` call `_root_.scala.StringContext` instead of just `StringContext` * Add a unit test
lloydmeta
added a commit
to lloydmeta/dotty
that referenced
this issue
Jul 8, 2018
* Make desugared `s""` call `_root_.scala.StringContext` instead of just `StringContext` to fix the initial issue * Add a unit test to lock in the change * Update StringInterpolatorOpt#unapply so that the StringInterpolator optimistation can work with the new change
allanrenucci
added a commit
that referenced
this issue
Jul 10, 2018
Fix #4732: Root the desugared call to StringContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:desugar
Desugaring happens after parsing but before typing, see desugar.scala
help wanted
itype:bug
fails to compile with Dotty and Scalac:
This is because the code snippet desugars to
Is this on purpose? An easy fix would be to desugar to
scala.StringContext("Hello").s()
The text was updated successfully, but these errors were encountered: