Skip to content

Add tests for dotd command #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Jan 22, 2018 · 2 comments
Closed

Add tests for dotd command #3886

smarter opened this issue Jan 22, 2018 · 2 comments
Assignees
@liufengyun
Labels
area:doctool area:testing itype:enhancement prio:low

Comments

@smarter
Copy link
Member

smarter commented Jan 22, 2018

It's currently not tested so we didn't notice when it was broken (see #3884).
@liufengyun
Copy link
Contributor

We have a test in lampepfl/homebrew-brew :

lampepfl/homebrew-brew#11

That's where we found it broke. We could add some of the script tests to the Dotty CI.

@liufengyun
Copy link
Contributor

There are also tests in packtest for each OS: https://github.com/lampepfl/packtest/blob/master/.travis.yml

@liufengyun liufengyun self-assigned this Jan 23, 2018
liufengyun added a commit to dotty-staging/dotty that referenced this issue Jan 23, 2018
@liufengyun
Fix scala#3886: add tests for dotc/dotr/dotd
dde5f28
@liufengyun liufengyun mentioned this issue Jan 23, 2018
Merged
liufengyun added a commit to dotty-staging/dotty that referenced this issue Jan 23, 2018
@liufengyun
Fix scala#3886: add tests for dotc/dotr/dotd
90a5ede
liufengyun added a commit that referenced this issue Jan 26, 2018
@liufengyun
Merge pull request #3892 from dotty-staging/fix-3886
764d3fe 
Fix #3886: add tests for dotc/dotr/dotd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liufengyun liufengyun

Labels
area:doctool area:testing itype:enhancement prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @liufengyun