-
Notifications
You must be signed in to change notification settings - Fork 1k
Add drone.yml and remove travis #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis, goodbye. Your last attempt of killing our beloved tut setup is not nice. I'm sorry, this is how life is. We just change partner. See urho3d/urho3d#651 for related discussions on memory leaks in Travis and Travis killing other processes that are memory intensive as tut.
I'm confused by the order of operations here. Why is there drone output about failed CI before this PR has been merged? |
Travis hasn't kicked out because it doesn't find a |
There's no Travis output in this PR's checks. Only broken drone output, claiming that coursier can't be found. |
Yes, there's no Travis output because Travis doesn't kick out any if there's no I'm working on fixing the drone output. |
e460c05
to
28bf254
Compare
@heathermiller This is finally ready for review, everything passes in Drone. I took the liberty to remove the coursier installation from the drone script and add coursier directly to the image we depend on. As a data point, Drone builds everything in ~5 minutes where Travis did it in around ~10 (this includes the optimization that we merged some hours ago). |
LGTM, thanks @jvican!! 🎉 |
Travis, goodbye. Your last attempt of killing our beloved tut setup is
not nice. I'm sorry, this is how life is. We just change partner.
See urho3d/urho3d#651 for related discussions
on memory leaks in Travis and Travis killing other processes that are
memory intensive as tut.