Skip to content

Add drone.yml and remove travis #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2017
Merged

Add drone.yml and remove travis #685

merged 4 commits into from
Feb 13, 2017

Conversation

jvican
Copy link
Member

@jvican jvican commented Feb 13, 2017

Travis, goodbye. Your last attempt of killing our beloved tut setup is
not nice. I'm sorry, this is how life is. We just change partner.

See urho3d/urho3d#651 for related discussions
on memory leaks in Travis and Travis killing other processes that are
memory intensive as tut.

Travis, goodbye. Your last attempt of killing our beloved tut setup is
not nice. I'm sorry, this is how life is. We just change partner.

See urho3d/urho3d#651 for related discussions
on memory leaks in Travis and Travis killing other processes that are
memory intensive as tut.
@heathermiller
Copy link
Member

I'm confused by the order of operations here. Why is there drone output about failed CI before this PR has been merged?

@jvican
Copy link
Member Author

jvican commented Feb 13, 2017

Travis hasn't kicked out because it doesn't find a travis.yml file, and Drone has already this repository enabled (because I did enable it in the admin panel). If it finds drone.yml it will try to build it. I'm now choosing the correct image that has both java and the correct ruby version, and this will be good to go.

@heathermiller
Copy link
Member

heathermiller commented Feb 13, 2017

There's no Travis output in this PR's checks. Only broken drone output, claiming that coursier can't be found.

@jvican
Copy link
Member Author

jvican commented Feb 13, 2017

Yes, there's no Travis output because Travis doesn't kick out any if there's no travis.yml file, and this commit removes it.

I'm working on fixing the drone output.

@jvican jvican force-pushed the master branch 2 times, most recently from e460c05 to 28bf254 Compare February 13, 2017 14:53
@jvican
Copy link
Member Author

jvican commented Feb 13, 2017

@heathermiller This is finally ready for review, everything passes in Drone. I took the liberty to remove the coursier installation from the drone script and add coursier directly to the image we depend on.

As a data point, Drone builds everything in ~5 minutes where Travis did it in around ~10 (this includes the optimization that we merged some hours ago).

@heathermiller
Copy link
Member

LGTM, thanks @jvican!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants