-
Notifications
You must be signed in to change notification settings - Fork 31
benchmark dotty compiler #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is currently crashing the Scala compiler due to scala/scala3#2670.
cc @smarter |
Hi @lrytz ! @olafurpg is already working on benchmarking infrastructure for dotty, you guys should collaborate, see https://github.com/dotty-staging/compiler-benchmark |
Nice! We should get this running on our machine so we have comparable results. |
Cool! I'd love to collaborate. Here is a rough summary of changes I made to the repo,
If you are interested in getting any of those changes into scala/compiler-benchmark, I may be able to pull out the necessary bits into a review-friendly PR. |
It'd be great if you could open a bug report for that. |
@smarter Will do. I spent a while trying to minimize that error, but then I got distracted with Scaladays preparations! It was related to Java annotations and default parameters. |
@olafurpg nice work! I think we should get everything merged here so that we can run the benchmarks on dotc and publish to the same database. We run through jenkins (https://scala-ci.typesafe.com/view/scala-bench/job/compiler-benchmark/528/parameters/), we'll have to do a few adjustments there too. |
Note, the benchmarks currently don't actually run with Dotty because of scala/scala3#2704. - scalac and dotc driver separated in src/main/{scalac,dotc}. - unit tests for rapic local iteration without the need to remember cli args. - `fork in run` is necessary for -usejavacp to work with compilation/run - `FileVisitOption.FOLLOW_LINKS` produces duplicate filenames, which causes "X is already compiled in this run" errors in Dotty.
Note, the benchmarks currently don't actually run with Dotty because of scala/scala3#2704. - scalac and dotc driver separated in src/main/{scalac,dotc}. - unit tests for rapic local iteration without the need to remember cli args. - `fork in run` is necessary for -usejavacp to work with compilation/run - `FileVisitOption.FOLLOW_LINKS` produces duplicate filenames, which causes "X is already compiled in this run" errors in Dotty.
Note, the benchmarks currently don't actually run with Dotty because of scala/scala3#2704. - scalac and dotc driver separated in src/main/{scalac,dotc}. - unit tests for rapic local iteration without the need to remember cli args. - `fork in run` is necessary for -usejavacp to work with compilation/run - `FileVisitOption.FOLLOW_LINKS` produces duplicate filenames, which causes "X is already compiled in this run" errors in Dotty.
Note, the benchmarks currently don't actually run with Dotty because of scala/scala3#2704. - scalac and dotc driver separated in src/main/{scalac,dotc}. - unit tests for rapic local iteration without the need to remember cli args. - `fork in run` is necessary for -usejavacp to work with compilation/run - `FileVisitOption.FOLLOW_LINKS` produces duplicate filenames, which causes "X is already compiled in this run" errors in Dotty.
Note, the benchmarks currently don't actually run with Dotty because of scala/scala3#2704. - When `scalaVersion := "0.x"`, then "src/main/dotc" is added to unmanagedSourceDirectories, otherwise "src/main/scalac" is added. - compilation/test checks the setup is OK without the need to remember cli args. - `fork in run` is necessary for -usejavacp to work with compilation/run - `FileVisitOption.FOLLOW_LINKS` produces duplicate filenames, which causes "X is already compiled in this run" errors in Dotty.
I just opened #31, which adds support to compile the benchmarks with dotty. |
Compile benchmark with Dotty, fixes #29.
Wip: https://github.com/scala/compiler-benchmark/compare/master...lrytz:dotty?expand=1
The text was updated successfully, but these errors were encountered: