Skip to content

Make Undefined a final val so that it can be constant-folded. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Sep 7, 2021

No description provided.

@sjrd sjrd requested a review from djspiewak September 7, 2021 20:00
@djspiewak djspiewak merged commit 25002da into scala-js:main Sep 7, 2021
@djspiewak
Copy link
Collaborator

@sjrd Interesting! I've seen scalac do weird things with final vals like this in the past but I didn't realize it affected constant folding in this way.

@sjrd sjrd deleted the final-val-undefined branch September 7, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants