Skip to content

Migrate FileReaderSync to dom #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Migrate FileReaderSync to dom #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,9 @@ FileReader[JC] def result: js.Any
FileReader[JO] val DONE: Short
FileReader[JO] val EMPTY: Short
FileReader[JO] val LOADING: Short
FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
FileReaderSync[JC] def readAsDataURL(blob: Blob): URL
FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
FocusEvent[JC] def bubbles: Boolean
FocusEvent[JC] def cancelBubble: Boolean
FocusEvent[JC] def cancelable: Boolean
Expand Down Expand Up @@ -24399,9 +24402,6 @@ crypto/package[SO] type BigInteger = Uint8Array
crypto/package[SO] type HashAlgorithmIdentifier = HashAlgorithm | String
crypto/package[SO] type KeyAlgorithmIdentifier = KeyAlgorithm | String
crypto/package[SO] @js.native @JSGlobal("crypto") val crypto: Crypto
experimental/FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
experimental/FileReaderSync[JC] def readAsDataURL(blob: Blob): dom.URL
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
experimental/Fullscreen[SO] (@deprecated in 2.0.0)
experimental/PointerLock[SO] def exitPointerLock(): Unit
experimental/PointerLock[SO] def movementX: Double
Expand Down Expand Up @@ -24811,6 +24811,7 @@ experimental/package[SO] type Body = dom.Body (@deprecated in 2.0.0)
experimental/package[SO] type BodyInit = dom.BodyInit (@deprecated in 2.0.0)
experimental/package[SO] type ByteString = dom.ByteString (@deprecated in 2.0.0)
experimental/package[SO] type Chunk[+T] = dom.Chunk[T] (@deprecated in 2.0.0)
experimental/package[SO] type FileReaderSync = dom.FileReaderSync (@deprecated in 2.0.0)
experimental/package[SO] type Headers = dom.Headers (@deprecated in 2.0.0)
experimental/package[SO] type HeadersInit = dom.HeadersInit (@deprecated in 2.0.0)
experimental/package[SO] type HttpMethod = dom.HttpMethod (@deprecated in 2.0.0)
Expand Down
7 changes: 4 additions & 3 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,9 @@ FileReader[JC] def result: js.Any
FileReader[JO] val DONE: Short
FileReader[JO] val EMPTY: Short
FileReader[JO] val LOADING: Short
FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
FileReaderSync[JC] def readAsDataURL(blob: Blob): URL
FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
FocusEvent[JC] def bubbles: Boolean
FocusEvent[JC] def cancelBubble: Boolean
FocusEvent[JC] def cancelable: Boolean
Expand Down Expand Up @@ -24399,9 +24402,6 @@ crypto/package[SO] type BigInteger = Uint8Array
crypto/package[SO] type HashAlgorithmIdentifier = HashAlgorithm | String
crypto/package[SO] type KeyAlgorithmIdentifier = KeyAlgorithm | String
crypto/package[SO] @js.native @JSGlobal("crypto") val crypto: Crypto
experimental/FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
experimental/FileReaderSync[JC] def readAsDataURL(blob: Blob): dom.URL
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
experimental/Fullscreen[SO] (@deprecated in 2.0.0)
experimental/PointerLock[SO] def exitPointerLock(): Unit
experimental/PointerLock[SO] def movementX: Double
Expand Down Expand Up @@ -24811,6 +24811,7 @@ experimental/package[SO] type Body = dom.Body (@deprecated in 2.0.0)
experimental/package[SO] type BodyInit = dom.BodyInit (@deprecated in 2.0.0)
experimental/package[SO] type ByteString = dom.ByteString (@deprecated in 2.0.0)
experimental/package[SO] type Chunk[+T] = dom.Chunk[T] (@deprecated in 2.0.0)
experimental/package[SO] type FileReaderSync = dom.FileReaderSync (@deprecated in 2.0.0)
experimental/package[SO] type Headers = dom.Headers (@deprecated in 2.0.0)
experimental/package[SO] type HeadersInit = dom.HeadersInit (@deprecated in 2.0.0)
experimental/package[SO] type HttpMethod = dom.HttpMethod (@deprecated in 2.0.0)
Expand Down
6 changes: 2 additions & 4 deletions ...ajs/dom/experimental/FileReaderSync.scala → ...cala/org/scalajs/dom/FileReaderSync.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package org.scalajs.dom.experimental
package org.scalajs.dom

import org.scalajs.dom
import org.scalajs.dom.Blob
import scala.scalajs.js
import scala.scalajs.js.annotation._
import scala.scalajs.js.typedarray.ArrayBuffer
Expand All @@ -24,7 +22,7 @@ class FileReaderSync() extends js.Object {
* operation is finished, the readyState becomes DONE, and the loadend is triggered. At that time, the result
* attribute contains a data: URL representing the file's data as base64 encoded string.
*/
def readAsDataURL(blob: Blob): dom.URL = js.native
def readAsDataURL(blob: Blob): URL = js.native

/** The readAsText method is used to read the contents of the specified Blob or File. When the read operation is
* complete, the readyState is changed to DONE, the loadend is triggered, and the result attribute contains the
Expand Down
4 changes: 4 additions & 0 deletions src/main/scala/org/scalajs/dom/experimental/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ package object experimental {
@deprecated("use dom.ResponseType instead", "2.0.0")
lazy val ResponseType: dom.ResponseType.type = dom.ResponseType

// old FileReaderSync.scala
@deprecated("use dom.FileReaderSync instead", "2.0.0")
type FileReaderSync = dom.FileReaderSync

// old Notification.scala

@deprecated("use dom.Notification instead", "2.0.0")
Expand Down