Skip to content

Should opaque types subtype String? #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armanbilge opened this issue Oct 11, 2021 · 6 comments · Fixed by #603
Closed

Should opaque types subtype String? #594

armanbilge opened this issue Oct 11, 2021 · 6 comments · Fixed by #603
Labels
question

Comments

@armanbilge
Copy link
Member

Came up in #592 (comment) but we deferred the decision.
@armanbilge armanbilge mentioned this issue Oct 11, 2021
Merged
@japgolly
Copy link
Contributor

We can close this now, right @armanbilge ?

@armanbilge
Copy link
Member Author

Actually not yet, we didn't make a decision on this since we can do it compatibly at a later stage. Would appreciate your insight here 😁

@japgolly
Copy link
Contributor

Oh right. Went and read the comment. Yeah sounds good to me, is there any reason not subtype String?

@armanbilge
Copy link
Member Author

Don't think so! I can make a PR with this, but it doesn't have to block the RC.

@japgolly
Copy link
Contributor

Actually it should only take a second. How about I regex up a PR and then cut an RC right after?

@armanbilge
Copy link
Member Author

Go ahead! You're too fast for me 😆 🐌

japgolly added a commit that referenced this issue Oct 17, 2021
@japgolly
Make opaque string types subtype String
42d6218 
Closes #594
@japgolly japgolly mentioned this issue Oct 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make opaque string types subtype String scala-js/scala-js-dom
2 participants
@japgolly @armanbilge