Skip to content

#619 ScalaExercises 2º Part #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2017
Merged

#619 ScalaExercises 2º Part #11

merged 3 commits into from
Mar 31, 2017

Conversation

AdrianRaFo
Copy link
Collaborator

Fixes #5 Exercises with nothing to fill in / impossible to complete

@AdrianRaFo AdrianRaFo requested review from raulraja and julienrf March 30, 2017 14:15
Copy link
Collaborator

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that!

* }
* }
*}}}
*
* Try to run the above code to see how the compiler informs us that
* we don’t handle all the cases in `nonExhaustiveDuration`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sould also update this sentence like “If we try to run …”

@AdrianRaFo
Copy link
Collaborator Author

One of the test failed but it's in other issue

@julienrf julienrf merged commit b079ce7 into master Mar 31, 2017
@julienrf julienrf deleted the arf-Fix_Empty_Exercises branch March 31, 2017 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants