uefi runtime: Increase default size of name buffer #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptf2
force-pushed
the
enlarge-default-name-buffer
branch
2 times, most recently
from
63ded99 to
7385a2f
Compare
|
Add a bullet on this change to " |
phip1611
approved these changes
Mar 21, 2025
phip1611
requested changes
Mar 21, 2025
Some firmware fails to update the "VariableNameSize" parameter passed into GetNextVariableName(). To work around this we will use a large default buffer size.
Address PR comments: update code comments, move `use alloc::vec` into appropriate cfg block.
Describe VariableKeys name buffer change.
phip1611
force-pushed
the
enlarge-default-name-buffer
branch
from
204e007 to
b43d34c
Compare
phip1611
approved these changes
Mar 21, 2025
nicholasbishop
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some firmware fails to update the "VariableNameSize" parameter passed into GetNextVariableName(). To work around this we will use a large default buffer size.