Add device path node types to uefi-raw #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a full crate path such as `crate::proto::device_path::hardware::BmcInterfaceType`, shorten it to just `device_path::hardware::BmcInterfaceType`. This will make it easier to use the same spec file for generating nodes in uefi-raw.
* Rename `gen_code_as_string` to `gen_uefi_code_as_string` * Factor out part of that function to a new `code_to_string` function
These nodes are very similar to the nodes generated in the `uefi` crate. The main difference is in DST nodes: instead of creating a trailing DST slice, a zero-length array is created instead. This ensures that pointers are thin, and matches the API style used elsewhere in `uefi-raw`.
nicholasbishop
force-pushed
the
bishop-raw-nodes-2
branch
from
2ef301c to
333d54e
Compare
phip1611
approved these changes
Oct 23, 2024
|
They are already optional in that they won't prevent the PR from being merged. I think I'd rather they didn't mark the PR red, though I'm not yet sure how to do that. |
|
@kukrimate FYI I'm hoping this covers the same stuff as #1435 -- if you have time, please let me know if this works for your use case, or if there's anything missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These nodes are very similar to the nodes generated in the
ueficrate. The main difference is in DST nodes: instead of creating a trailing DST slice, a zero-length array is created instead. This ensures that pointers are thin, and matches the API style used elsewhere inuefi-raw.Closes #1441
Checklist