uefi: Stop enabling error_in_core feature
#1194
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature has been stabilized in latest nightly, so no need to enable it. All the uses of it (`impl core::error::Error for for ...`) are still gated by the `unstable` feature, so there's no change for users on the stable channel.
|
I'll go ahead and merge this to fix CI. |
|
Once this lands in rustc stable, and two more stable releases have passed (our MSRV policy), we remove the feature gate where it is no longer needed and create a new release, right? |
|
Yep. Filed #1200 as a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the CI errors.
This feature has been stabilized in latest nightly, so no need to enable it. All the uses of it (
impl core::error::Error for for ...) are still gated by theunstablefeature, so there's no change for users on the stable channel.Checklist