Skip to content

Minor import/export cleanups #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2024
Merged

Minor import/export cleanups #1144

merged 3 commits into from
Apr 21, 2024

Conversation

nicholasbishop
Copy link
Member

@nicholasbishop nicholasbishop commented Apr 20, 2024 •
edited by phip1611
Loading

  • All of the macros from uefi_macros are imported into the uefi crate. Consistently use those imports everywhere, rather than reimporting from uefi_macros.
  • Consistently import items in the uefi crate with crate:: instead of uefi::.
  • Clean up unnecessary uses of self::.

Should be no change to the public API from this.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
uefi: Clean up macro imports
b0e8dd2 
All of the macros from uefi_macros are imported into the uefi
crate. Consistently use those imports everywhere, rather than reimporting from
`uefi_macros`.
@nicholasbishop
uefi: Clean up imports of uefi
063af74 
Consistently import items in the `uefi` crate with `crate::` instead of
`uefi::`.
@nicholasbishop
uefi: Clean up unnecessary uses of self::
826e559
phip1611
phip1611 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phip1611 phip1611 added this pull request to the merge queue Apr 21, 2024
Merged via the queue into rust-osdev:main with commit ddb81bd Apr 21, 2024
12 checks passed
@nicholasbishop nicholasbishop deleted the bishop-cleanup-macros-imports branch April 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611