-
Notifications
You must be signed in to change notification settings - Fork 215
Add support for adding a ramdisk to the disk image #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,22 +17,31 @@ mod mbr; | |
mod pxe; | ||
|
||
const KERNEL_FILE_NAME: &str = "kernel-x86_64"; | ||
const RAMDISK_FILE_NAME: &str = "ramdisk-x86_64"; | ||
const BIOS_STAGE_3: &str = "boot-stage-3"; | ||
const BIOS_STAGE_4: &str = "boot-stage-4"; | ||
|
||
/// Create disk images for booting on legacy BIOS systems. | ||
pub struct BiosBoot { | ||
kernel: PathBuf, | ||
ramdisk: Option<PathBuf>, | ||
} | ||
|
||
impl BiosBoot { | ||
/// Start creating a disk image for the given bootloader ELF executable. | ||
pub fn new(kernel_path: &Path) -> Self { | ||
Self { | ||
kernel: kernel_path.to_owned(), | ||
ramdisk: None, | ||
} | ||
} | ||
|
||
/// Add a ramdisk file to the image | ||
pub fn set_ramdisk(&mut self, ramdisk_path: &Path) -> &mut Self { | ||
self.ramdisk = Some(ramdisk_path.to_owned()); | ||
self | ||
} | ||
|
||
/// Create a bootable UEFI disk image at the given path. | ||
pub fn create_disk_image(&self, out_path: &Path) -> anyhow::Result<()> { | ||
let bootsector_path = Path::new(env!("BIOS_BOOT_SECTOR_PATH")); | ||
|
@@ -61,12 +70,18 @@ impl BiosBoot { | |
fn create_fat_partition(&self) -> anyhow::Result<NamedTempFile> { | ||
let stage_3_path = Path::new(env!("BIOS_STAGE_3_PATH")); | ||
let stage_4_path = Path::new(env!("BIOS_STAGE_4_PATH")); | ||
let has_rd_path = self.ramdisk.is_some(); | ||
let binding = self.ramdisk.as_deref(); | ||
let ramdisk_path = binding.unwrap_or(Path::new("no-such-file")); | ||
let kernel_path = self.kernel.as_path(); | ||
|
||
let mut files = BTreeMap::new(); | ||
files.insert(KERNEL_FILE_NAME, self.kernel.as_path()); | ||
files.insert(KERNEL_FILE_NAME, kernel_path); | ||
files.insert(BIOS_STAGE_3, stage_3_path); | ||
files.insert(BIOS_STAGE_4, stage_4_path); | ||
|
||
if let Some(ramdisk_path) = &self.ramdisk { | ||
files.insert(RAMDISK_FILE_NAME, ramdisk_path); | ||
} | ||
let out_file = NamedTempFile::new().context("failed to create temp file")?; | ||
fat::create_fat_filesystem(files, out_file.path()) | ||
.context("failed to create BIOS FAT filesystem")?; | ||
|
@@ -78,13 +93,23 @@ impl BiosBoot { | |
/// Create disk images for booting on UEFI systems. | ||
pub struct UefiBoot { | ||
kernel: PathBuf, | ||
ramdisk: Option<PathBuf>, | ||
} | ||
|
||
impl UefiBoot { | ||
/// Start creating a disk image for the given bootloader ELF executable. | ||
pub fn new(kernel_path: &Path) -> Self { | ||
Self { | ||
kernel: kernel_path.to_owned(), | ||
ramdisk: None, | ||
} | ||
} | ||
|
||
/// Add a ramdisk file to the disk image | ||
pub fn with_ramdisk(&self, ramdisk_path: &Path) -> Self { | ||
Self { | ||
kernel: self.kernel.clone(), | ||
ramdisk: Some(ramdisk_path.to_owned()), | ||
} | ||
} | ||
|
||
|
@@ -121,10 +146,17 @@ impl UefiBoot { | |
/// Creates an UEFI-bootable FAT partition with the kernel. | ||
fn create_fat_partition(&self) -> anyhow::Result<NamedTempFile> { | ||
let bootloader_path = Path::new(env!("UEFI_BOOTLOADER_PATH")); | ||
|
||
let has_rd_path = self.ramdisk.is_some(); | ||
let binding = self.ramdisk.as_deref(); | ||
let ramdisk_path = binding.unwrap_or(Path::new("no-such-file")); | ||
let kernel_path = self.kernel.as_path(); | ||
let mut files = BTreeMap::new(); | ||
files.insert("efi/boot/bootx64.efi", bootloader_path); | ||
files.insert(KERNEL_FILE_NAME, self.kernel.as_path()); | ||
files.insert(KERNEL_FILE_NAME, kernel_path); | ||
|
||
if has_rd_path { | ||
files.insert(RAMDISK_FILE_NAME, ramdisk_path); | ||
} | ||
Comment on lines
+157
to
+159
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above (use |
||
|
||
let out_file = NamedTempFile::new().context("failed to create temp file")?; | ||
fat::create_fat_filesystem(files, out_file.path()) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above:
set_ramdisk(&mut self, ramdisk_path: &Path) -> &mut Self
.