This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Change Uri.parse to Uri.file #469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
However this uri generated from 'Uri.file' still doesn't have the "external" and "fsPath" field. Do we have a functions that will generate all these data? |
|
Thanks for the PR and sorry for the delay in reviewing. Is this PR still necessary? If so could you rebase it please? I'm not sure about your question, where are these fields required? |
|
The relevant code is rolled back in 0.5.2, i think. This was an attempt to fix an issue in those removed code. I'm not sure if there's plan for those code coming back. |
|
Merged as a part of #759 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468