Is the parser undergoing refactoring? #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK not really. I would just remove that. |
smanilov
added a commit
to smanilov/rustc-dev-guide
that referenced
this pull request
May 12, 2025
Discussed in PR rust-lang#2378; the note was outdated.
This comment has been minimized.
This comment has been minimized.
Discussed in PR 2378; the note was outdated.
Removed. Also updated commit message to reference this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested change is more of conversation starter. I could track the introduction of the message to a50b8f1 which is from Nov 2019.
Is the refactor still undergoing? Is there a tracking issue for it?
If not, the N.B. can just be deleted... but maybe the document would need to be updated with the changes from the refactor if that's the case?