Skip to content

"Testing infrastructure" isn't up-to-date #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PotHix opened this issue Nov 6, 2019 · 5 comments · Fixed by #505
Closed

"Testing infrastructure" isn't up-to-date #500

PotHix opened this issue Nov 6, 2019 · 5 comments · Fixed by #505

Comments

@PotHix
Copy link
Contributor

PotHix commented Nov 6, 2019

It seems the documentation for the testing infrastructure is misleading. I can see the tests on Travis and AppVeyor ran 3 months ago.

I believe it's related to the migration to Azure Pipelines, but not entirely sure to contribute.

Either way, the links available for Travis and AppVeyor are not useful currently, so it's certaily an issue.
@JohnTitor
Copy link
Member

Good catch! Indeed, we should replace them with Azure Pipelines'.

@PotHix
Copy link
Contributor Author

PotHix commented Nov 6, 2019

@JohnTitor do we have more info about that available anywhere? I can try to submit a PR for it.

@JohnTitor
Copy link
Member

We should update it as follows:

  • The sentence Travis will automatically launch a build that will run all tests on a single configuration (x86-64 linux) should be Azure Pipelines will automatically [...] all tests on some configurations (x86_64-gnu-llvm-6.0 linux. x86_64-gnu-tools linux, mingw-check linux)
  • The sentence When a PR is approved, it goes into a queue where merges are tested one at a time on a wide set of platforms using Travis and Appveyor (currently over 50 different configurations). should be [...] on a wide set of platforms using Azure Pipelines (currently over 50 different configurations).
    • I'm not sure about the number of configurations but I guess it is unchanged

CC: @spastorino

@JohnTitor JohnTitor changed the title Test infrastructure "Testing infrastructure" isn't up-to-date Nov 6, 2019
PotHix added a commit to PotHix/rustc-guide that referenced this issue Nov 8, 2019
@PotHix
Update the "Testing infrastructure" section
989028b 
The testing infrastructure was migrated from Travis and AppVeyor to
Azure Pipelines some time ago. This commit updates the documentation to
reflect this change.

Fixes rust-lang#500.
@PotHix PotHix mentioned this issue Nov 8, 2019
Merged
PotHix added a commit to PotHix/rustc-guide that referenced this issue Nov 8, 2019
@PotHix
Update the "Testing infrastructure" section
95f395b 
The testing infrastructure was migrated from Travis and AppVeyor to
Azure Pipelines some time ago. This commit updates the documentation to
reflect this change.

Fixes rust-lang#500.
@PotHix
Copy link
Contributor Author

PotHix commented Nov 8, 2019

Proposed a PR with the changes mentioned here. I can see there is another reference to Travis on Testing on emulators, but I'm not sure if we're still using that setup. Please let me know if I should just change to Azure Pipelines or if it should change entirely.

@mark-i-m
Copy link
Member

mark-i-m commented Nov 8, 2019

TBH, I'm not sure. I think your current PR is good though. If we discovered more we can do that change in another PR

mark-i-m pushed a commit that referenced this issue Nov 8, 2019
@PotHix @mark-i-m
Update the "Testing infrastructure" section
a7beb12 
The testing infrastructure was migrated from Travis and AppVeyor to
Azure Pipelines some time ago. This commit updates the documentation to
reflect this change.

Fixes #500.
mark-i-m pushed a commit to spastorino/rustc-dev-guide that referenced this issue Jan 2, 2020
@PotHix @mark-i-m
Update the "Testing infrastructure" section
a27c724 
The testing infrastructure was migrated from Travis and AppVeyor to
Azure Pipelines some time ago. This commit updates the documentation to
reflect this change.

Fixes rust-lang#500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the "Testing infrastructure" section PotHix/rustc-guide
3 participants
@PotHix @mark-i-m @JohnTitor