Update Clippy #80623

flip1995 · 2021-01-02T16:01:05Z

Biweekly Clippy update.

This includes a Cargo.lock update for the recent Clippy version bump.

* last minor improvements

Co-authored-by: Takayuki Nakata <[email protected]>

…t is missing on a nightly Clippy should always be available on nightly because we are gating on it in rustcs CI.

readme: remove paragraph about installing clippy manually on ci, if it is missing on a nightly Clippy should always be available on nightly because we are gating on it in rustcs CI. changelog: remove outdated readme paragraph

…, r=llogiq Don't trigger large_enum_variant in external macros Closes rust-lang#1776 (the potential JSON output issue is not something we can fix in Clippy and I can't reproduce it anymore) changelog: Don't trigger [`large_enum_variant`] in external macros

This most likely no longer works since we are pinning clippy on a specific nightly now. "cargo run" would try to compile clippy with whatever version the project we want to check demands. Also building clippy yourself to run it on a project is not really needed anymore since clippy is shipped with official rust releases. Fixes rust-lang#6489

remove clone in manual_async_fn lint changelog: none

Added from_over_into lint Closes rust-lang#6456 Added a lint that searches for implementations of `Into<..>` and suggests to implement `From<..>` instead, as it comes with a default implementation of `Into`. Category: style. changelog: added `from_over_into` lint

readme: remove paragraph about executing clippy via "cargo run .." This most likely no longer works since we are pinning clippy on a specific nightly now. "cargo run" would try to compile clippy with whatever version the project we want to check demands. Also building clippy yourself to run it on a project is not really needed anymore since clippy is shipped with official rust releases. Fixes rust-lang#6489 changelog: none

The default value for a field type does not necessarily match the default value for that field in the struct Default.

There is already an assertion that consecutive lines assign to a struct field.

…=ebroto Revert "Pass Clippy args also trough RUSTFLAGS" Reverts rust-lang/rust-clippy#6441 r? `@ebroto` changelog: Revert "Pass Clippy args also trough RUSTFLAGS"

ci: test cargo clippy --fix -Zunstable-options Make sure we catch cases like rust-lang/rust-clippy#6487 in CI in the future. --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none

…killercup Website issue tracker link and better search performance This PR implements some improvements to the website: 1. Added a "Search on Github" link to the "Known problems" section (Closes rust-lang#5386) ![example_3](https://user-images.githubusercontent.com/17087237/102718215-e9f12500-42de-11eb-8c1b-487f8184aaf7.png) <details> <summary>Another mock up I created with the GitHub logo</summary> ![example_2](https://user-images.githubusercontent.com/17087237/102718281-3472a180-42df-11eb-99b8-7f6d76da2b55.png) </details> 2. Only starting the search after three letters and improving the search performance in general. (Followup rust-lang#6477) ### Testing These changes can be tested locally by: 1. Clone this branch 2. Download the current lint index from the [gh-pages branch](https://github.com/rust-lang/rust-clippy/blob/gh-pages/master/lints.json) 3. Put it next to the `util/gh-pages/index.html` and open the html file. Make sure that it can load the lint data. (Browsers can be a bit iffy when opening a local html page and loading data) ### Sources for search performance: 1. [A stackoverflow about angular filter performance](https://stackoverflow.com/questions/26876514/optimize-angular-filter-performance) * I selected a search debounce of 50ms that's fast enough to catch fast deletion and typing but responsive enough to not bother the user 2. [A stackoverflow about string comparison speeds](https://stackoverflow.com/questions/5296268/fastest-way-to-check-a-string-contain-another-substring-in-javascript) 3. [JS benchmarks for string search performance (`indexOf` seams to be the best)](https://jsben.ch/9cwLJ) Note: The performance is still a bit poor when going from a specific lint to no search filter. I suspect that angular is recreating all lint items when the filter is cleared causing a major lag spike. The filter functions is at least optimized for little to no search. --- changelog: Added a "Search on GitHub" link to the website

…ickets.

fix ci on master branch; run the --fix test in the correct directory Turned out the --fix test was run in the wrong directory. *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none

- Adds optional default values to const generic parameters in the AST and HIR - Parses these optional default values - Adds a `const_generics_defaults` feature gate

Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021.

Initial support for Rust 2021. Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021. changelog: Added support for Rust 2021.

Rustup r? `@ghost` changelog: none

rust-log-analyzer · 2021-01-02T16:38:51Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  EXTRA_VARIABLES: {
 "CI_ONLY_WHEN_SUBMODULES_CHANGED": 1
##[endgroup]
adding extra environment variable CI_ONLY_WHEN_SUBMODULES_CHANGED
linux builder detected, using docker to run the build
##[group]Run src/ci/scripts/should-skip-this.sh
---
  CACHE_DOMAIN: ci-caches.rust-lang.org
  CI_ONLY_WHEN_SUBMODULES_CHANGED: 1
  IMAGE: x86_64-gnu-tools
##[endgroup]
Executing the job since clippy subtree was updated
with:
  github_token: ***
  check_every_seconds: 60
env:
---
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s


running 2 tests
test check_that_clippy_has_the_same_major_version_as_rustc ... FAILED

failures:


---- check_that_clippy_has_the_same_major_version_as_rustc stdout ----
thread 'check_that_clippy_has_the_same_major_version_as_rustc' panicked at 'failed to run `rustc --version`: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/tools/clippy/tests/versioncheck.rs:37:14


failures:
failures:
    check_that_clippy_has_the_same_major_version_as_rustc
test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s

error: test failed, to rerun pass '--test versioncheck'

matthiaskrgr · 2021-01-02T16:51:39Z

---- check_that_clippy_has_the_same_major_version_as_rustc stdout ----
thread 'check_that_clippy_has_the_same_major_version_as_rustc' panicked at 'failed to run `rustc --version`: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/tools/clippy/tests/versioncheck.rs:37:14

Mmh, simply calling rustc does not work as part of x.py test :/

edit: feel free to temporarily disable the test. I'll need to figure out how x.py provides its rustc to the tools

flip1995 · 2021-01-02T17:03:32Z

I'll need to figure out how x.py provides its rustc to the tools

@matthiaskrgr It should work with RUSTC_REAL. Let's wait for CI.

matthiaskrgr · 2021-01-02T17:07:15Z

@matthiaskrgr It should work with RUSTC_REAL. Let's wait for CI.

Does that also work with our compiletest-based setup in the clippy repo?

flip1995 · 2021-01-02T17:13:38Z

I just synced back 5dd64b3 locally and it passed the Clippy test suite. So yes, this works now for both repos, rust-clippy and rust.

Manishearth · 2021-01-02T17:28:29Z

@bors r+

bors · 2021-01-02T17:28:31Z

📌 Commit 5dd64b3 has been approved by Manishearth

bors · 2021-01-03T00:55:31Z

⌛ Testing commit 5dd64b3 with merge 18d855b...

Manishearth · 2021-01-03T01:35:12Z

@bors p=2

bors · 2021-01-03T03:43:21Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 18d855b to master...

1c3t3a and others added 30 commits December 19, 2020 17:00

Added from_over_into lint

a451b2a

Added MSRV and fixed typo

dd005c1

Website issue tracker link and better search performance

97f5db9

* last minor improvements

Merge commit '4911ab124c481430672a3833b37075e6435ec34d' into clippyup

f03edfd

Fixed error messages

7e641c8

Update clippy_lints/src/from_over_into.rs

0d6c128

Co-authored-by: Takayuki Nakata <[email protected]>

Don't trigger large_enum_variant in external macros

12bd244

readme: remove paragraph about installing clippy manually on ci, if i…

19ace28

…t is missing on a nightly Clippy should always be available on nightly because we are gating on it in rustcs CI.

Update from_over_into.stderr

53f4d43

ci: test cargo clippy --fix -Zunstable-options

d6a7ebc

remove clone in manual_async_fn lint

af22613

Auto merge of rust-lang#6497 - matthiaskrgr:clone_1, r=flip1995

4b233c8

remove clone in manual_async_fn lint changelog: none

Fix default initialized fields in suggestion

8bdf34e

The default value for a field type does not necessarily match the default value for that field in the struct Default.

Remove redundant shadow check

73ce34a

There is already an assertion that consecutive lines assign to a struct field.

Fix field_reassign_with_default for private fields

c6450c7

Revert "Pass Clippy args also trough RUSTFLAGS"

7fa1d78

Fixed a value spelling mistake

f055e7f

Auto merge of rust-lang#6498 - rust-lang:revert-6441-use_rustflags, r…

4772eb8

…=ebroto Revert "Pass Clippy args also trough RUSTFLAGS" Reverts rust-lang/rust-clippy#6441 r? `@ebroto` changelog: Revert "Pass Clippy args also trough RUSTFLAGS"

Special sync of 'e89801553ddbaccdeb2eac4db08900edb51ac7ff'

88491e2

ISSUE_TEMPLATE: add templates for false negative and false positive t…

3687de2

…ickets.

ci: run cargo clippy --fix -Zunstable-options in the correct directory.

2218dd6

Fix a style of texts in map_err_ignore

e1743ef

JulianKnodt and others added 10 commits January 1, 2021 10:55

first pass at default values for const generics

48dec84

- Adds optional default values to const generic parameters in the AST and HIR - Parses these optional default values - Adds a `const_generics_defaults` feature gate

Initial support for Rust 2021.

e5a1f22

Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021.

Merge remote-tracking branch 'upstream/master' into rustup

d93692e

Bump nightly version to 2021-01-02

db268f8

Use rustc --version in versioncheck

106ca96

Bump Clippy version to 0.1.51

e4fbc5f

Auto merge of rust-lang#6536 - flip1995:rustup, r=flip1995

1fcc74c

Rustup r? `@ghost` changelog: none

Merge commit '1fcc74cc9e03bc91eaa80ecf92976b0b14b3aeb6' into clippyup

100c793

Update Cargo.lock

d35d827

rust-highfive assigned Manishearth Jan 2, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2021

Use bootstrap rustc for versioncheck in Clippy

5dd64b3

flip1995 force-pushed the clippyup branch from f1f14ef to 5dd64b3 Compare January 2, 2021 17:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2021

bors merged commit 18d855b into rust-lang:master Jan 3, 2021

rustbot added this to the 1.51.0 milestone Jan 3, 2021

flip1995 deleted the clippyup branch January 3, 2021 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #80623

Update Clippy #80623

flip1995 commented Jan 2, 2021

rust-log-analyzer commented Jan 2, 2021

matthiaskrgr commented Jan 2, 2021 •

edited

Loading

flip1995 commented Jan 2, 2021 •

edited

Loading

matthiaskrgr commented Jan 2, 2021

flip1995 commented Jan 2, 2021

Manishearth commented Jan 2, 2021

bors commented Jan 2, 2021

bors commented Jan 3, 2021

Manishearth commented Jan 3, 2021

bors commented Jan 3, 2021

Update Clippy #80623

Update Clippy #80623

Conversation

flip1995 commented Jan 2, 2021

rust-log-analyzer commented Jan 2, 2021

matthiaskrgr commented Jan 2, 2021 • edited Loading

flip1995 commented Jan 2, 2021 • edited Loading

matthiaskrgr commented Jan 2, 2021

flip1995 commented Jan 2, 2021

Manishearth commented Jan 2, 2021

bors commented Jan 2, 2021

bors commented Jan 3, 2021

Manishearth commented Jan 3, 2021

bors commented Jan 3, 2021

matthiaskrgr commented Jan 2, 2021 •

edited

Loading

flip1995 commented Jan 2, 2021 •

edited

Loading