Skip to content

Add tests for a few issues which can now be closed #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexcrichton
Copy link
Member

Closes #5844

@huonw
Copy link
Member

huonw commented Jul 23, 2013

There's already a test for the Unfoldr ICE. (I believe that issue is a duplicate, because I vaguely remember closing an issue when I fixed it.)

@alexcrichton
Copy link
Member Author

Should both tests be included though? The issue mentioned that the error was an ICE, not a normal compiler error. Even with the run-pass test it's probably a good idea to ensure the compiler also doesn't horribly die when given invalid input.

@huonw
Copy link
Member

huonw commented Jul 23, 2013

Yeah, I fixed an ICE. (Obviously it's fine to have both... but the files are essentially the same, so it's possibly pointless.)

@alexcrichton
Copy link
Member Author

Did the ICE happen when the code had the correct order of arguments for the issue? If so, then the cfail test is superfluous.

@huonw
Copy link
Member

huonw commented Jul 23, 2013

Oh! I misread the test; but the order of arguments was changed since that issue was filed (b9cf6a3) and so I think that wasn't the underlying problem.

@alexcrichton
Copy link
Member Author

Updated to remove the redundant test.

@bors bors closed this Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pub extern functions aren't considered unsafe from other crates
3 participants