More naming cleanup of syntax::ast types. #7903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelwoerister: looks like this needs to be rebased already |
…rate_cfg. `crate => Crate` `local => Local` `blk => Block` `crate_num => CrateNum` `crate_cfg => CrateConfig` Also, Crate and Local are not wrapped in spanned<T> anymore.
|
Rebased |
bors
added a commit
that referenced
this pull request
Jul 22, 2013
Continuation of #7826. AST spanned<T> refactoring, AST type renamings: `crate => Crate` `local => Local` `blk => Block` `crate_num => CrateNum` `crate_cfg => CrateConfig` `field => Field` Also, Crate, Field and Local are not wrapped in spanned<T> anymore.
| @@ -33,7 +33,7 @@ trait fake_ext_ctxt { | |||
| type fake_session = parse::parse_sess; | |||
|
|
|||
| impl fake_ext_ctxt for fake_session { | |||
| fn cfg() -> ast::crate_cfg { ~[] } | |||
| fn cfg() -> ast::Crate_cfg { ~[] } | |||
There was a problem hiding this comment.
Shouldn't this be CrateConfig as above?
There was a problem hiding this comment.
Yes, it should :/
I always run make check before a PR or after a rebase, but I guess this does not run the full-deps tests, does it?
Thanks for pointing this out!
There was a problem hiding this comment.
Oh, and I just saw some of the above tests are x-failed, so they slip through the compiler checks too.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
Fix rust-lang#7903 Fixes rust-lang#7903 (cc: `@Arnavion)` changelog: none (bug is in same release) r? `@camsteffen`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7826.
AST spanned refactoring, AST type renamings:
crate => Cratelocal => Localblk => Blockcrate_num => CrateNumcrate_cfg => CrateConfigfield => FieldAlso, Crate, Field and Local are not wrapped in spanned anymore.