-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove unnecessary unsafe block around calls to discriminant_value #77821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since 63793 the discriminant_value intrinsic is safe to call. Remove unnecessary unsafe block around calls to this intrinsic in built-in derive macros.
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
493bfad
to
50da126
Compare
Seems like this might impact perf due to the reduced amount of code generated. @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 50da126 with merge 90c516e222e0c4c6698cf58b124d30881de8bf3c... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 90c516e222e0c4c6698cf58b124d30881de8bf3c with parent bc74dd7, future comparison URL. |
Finished benchmarking try commit (90c516e222e0c4c6698cf58b124d30881de8bf3c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit 50da126 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Since 63793 the discriminant_value intrinsic is safe to call. Remove
unnecessary unsafe block around calls to this intrinsic in built-in
derive macros.