Update musl to 1.1.22 #61252
Update musl to 1.1.22 #61252
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| @@ -3,7 +3,7 @@ | |||
| # | |||
| # Versions of the toolchain components are configurable in `musl-cross-make/Makefile` and | |||
| # musl unlike GLIBC is forward compatible so upgrading it shouldn't break old distributions. | |||
| # Right now we have: Binutils 2.27, GCC 6.3.0, musl 1.1.18 | |||
| # Right now we have: Binutils 2.27, GCC 6.3.0, musl 1.1.22 | |||
There was a problem hiding this comment.
This seems wrong. Looking at https://github.com/richfelker/musl-cross-make/blob/v0.9.7/Makefile, this still uses musl 1.1.18. Maybe you want to update to v0.9.8, or do this as another PR?
|
cc @mati865 in case you interested. |
|
I saw it but |
This is the latest available version. I noticed Rust wasn't using the latest version when I attempted to have Cargo link object files produced outside of Cargo / Rust's toolchain and was getting missing symbol errors. Those missing symbols were added in 1.1.21 and 1.1.22. I'm not fully sure of the implications of this change or how comprehensive the test coverage is. Upstream changes in 1.1.21 and 1.1.22 can be found at https://git.musl-libc.org/cgit/musl/tree/WHATSNEW?h=v1.1.22&id=e97681d6f2c44bf5fa9ecdd30607cb63c780062e#n1989.
|
I saw that reference to musl 1.1.18 and figured it was missed when musl was last updated from 1.1.18 to 1.1.20. But I see now it belongs to an external project. I may very well submit another PR to get musl-cross-make bumped to the latest/greatest versions. |
|
As far as I can tell, this PR is harmless but won't be useful for you, because dist-x86_64-musl does not use musl.sh at all. It uses musl-toolchain.sh. |
|
Note: another PR was #61300 and it got merged. |
|
Gentle ping on review. |
|
@bors: r+ |
|
@bors: r+ |
|
📌 Commit aaf6698 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit aaf6698 with merge ebcd2b81c2ff69b9cba1f33e3e8312ef448ab510... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors: retry |
bors
added
S-waiting-on-bors
Update musl to 1.1.22 This is the latest available version. I noticed Rust wasn't using the latest version when I attempted to have Cargo link object files produced outside of Cargo / Rust's toolchain and was getting missing symbol errors. Those missing symbols were added in 1.1.21 and 1.1.22. I'm not fully sure of the implications of this change or how comprehensive the test coverage is. Upstream changes in 1.1.21 and 1.1.22 can be found at https://git.musl-libc.org/cgit/musl/tree/WHATSNEW?h=v1.1.22&id=e97681d6f2c44bf5fa9ecdd30607cb63c780062e#n1989.
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
This is the latest available version. I noticed Rust wasn't using the
latest version when I attempted to have Cargo link object files produced
outside of Cargo / Rust's toolchain and was getting missing symbol
errors. Those missing symbols were added in 1.1.21 and 1.1.22.
I'm not fully sure of the implications of this change or how
comprehensive the test coverage is. Upstream changes in 1.1.21 and
1.1.22 can be found at
https://git.musl-libc.org/cgit/musl/tree/WHATSNEW?h=v1.1.22&id=e97681d6f2c44bf5fa9ecdd30607cb63c780062e#n1989.