rustc: Fix some ThinLTO internalization #45215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
thin-lto-reference-more
branch
from
5cd5a78 to
e4b1536
Compare
|
Thank you, Alex! @bors r+ |
|
📌 Commit e4b1536 has been approved by |
|
⌛ Testing commit e4b1536918a01ed6c78b056b37a70315e43a6d2b with merge 91c17361d07433ec9a11ed3ed023bb588984e89c... |
kennytm
added
the
S-waiting-on-bors
|
💔 Test failed - status-travis |
|
Legit. You forgot to move some auxiliary files 😄 |
kennytm
added
S-waiting-on-author
First the `addPreservedGUID` function forgot to take care of "alias" summaries. I'm not 100% sure what this is but the current code now matches upstream. Next the `computeDeadSymbols` return value wasn't actually being used, but it needed to be used! Together these should... Closes rust-lang#45195
alexcrichton
force-pushed
the
thin-lto-reference-more
branch
from
e4b1536 to
2e1c4cd
Compare
|
@bors: r=michaelwoerister |
|
📌 Commit 2e1c4cd has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 2e1c4cd with merge 07adde34d967efad0b397f6dd6b4793d8ce49b7f... |
|
💔 Test failed - status-travis |
|
@bors retry The build got spuriously cancelled? |
bors
added a commit
that referenced
this pull request
Oct 15, 2017
…lwoerister rustc: Fix some ThinLTO internalization First the `addPreservedGUID` function forgot to take care of "alias" summaries. I'm not 100% sure what this is but the current code now matches upstream. Next the `computeDeadSymbols` return value wasn't actually being used, but it needed to be used! Together these should... Closes #45195
|
☀️ Test successful - status-appveyor, status-travis |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First the
addPreservedGUIDfunction forgot to take care of "alias" summaries.I'm not 100% sure what this is but the current code now matches upstream. Next
the
computeDeadSymbolsreturn value wasn't actually being used, but it neededto be used! Together these should...
Closes #45195